ULOG #6: Adding #ulog-quotes Feed Caption and Bug Fix for Wrong Rendering of Editor

Here were some of the latest developments on ulogs.org.

Repository

https://github.com/surpassinggoogle/UlogsV2

1) (Feature) Addition of Caption for #ulog-quotes Feed

Feature
Pull Requests
PR #57 & PR #60

This is to address ticket #52 in github. It's a simple addition of text on the #ulog-quotes feed to inspire readers to share their favorite or self-created quotes.

There were two files edited for this feature. One was for Feed.less which basically added a style class that will add a 20 pixel margin at the bottom of the caption, and Page.js which is where the main logic to display the caption is coded.

There were actually two PRs related to this feature because there was a misunderstanding regarding its specification. I thought that the caption was supposed to be displayed only when the user visited ulogs.org/created/ulog-quotes. However, as per chat with Terry, he also wanted the caption on other filters - trending, new, active, and hot. As such, the second part of the implementation was PR #60 which basically changed the checking from location.pathname to just the category.

2) (Bugfix) Clicking Comment Button from Post Feed with #editor as the First Tag (Main Category) Redirects to the Editor and not the Comment Section

Before
After
editor-render-comment

This is the same with issue #2096 in busy.org. This change will only display the editor when the user exactly visits the /editor location.

The file changed was src/common/routes.js to only render the Editor component when the user exactly visits the /editor location.

https://github.com/surpassinggoogle/UlogsV2/pull/67

Lesson Learned

A common misunderstanding in software development is understanding a feature's specification - when and where should something be rendered. This issue or problem surfaced in the implementation of #52. What may be common sense to others may not be that common to your developer. (Developers usually just focus on what's written and somehow overlook things that are obvious to the product owner)

GitHub Account

https://github.com/eastmaels

This post was made from https://ulogs.org

H2
H3
H4
Upload from PC
Video gallery
3 columns
2 columns
1 column
12 Comments